On Thu, Mar 24, 2011 at 06:58:09PM +0200, amir73il@xxxxxxxxxxxxxxxxxxxxx wrote: > From: Amir Goldstein <amir73il@xxxxxxxxxxxx> > > In preparation for the next patch, the function ext4_add_groupblocks() > is moved to mballoc.c, where it could use some static functions. > > I also fixed a checkpatch warning and replaced obsolete get_undo_access > for bitmap with get_write_access. > > Signed-off-by: Amir Goldstein <amir73il@xxxxxxxxxxxx> Please don't move code and make changes in one patch. #1, it's hard to review changes that happened in the middle of code movement. #2, if there has been any changes in the source function caused by other patches, I can't regenerate a patch by simply redoing the function move --- I have to reverse engineer the change that happened under the cover of code movement, regnerate the patch, and then redo the change. I've split this into two patches, one which is just a simple code movement (note that I also moved the function declaration in ext4.h so it function is listed under the correct .c file), and the second which changed the use of ext4_journal_get_undo_access to ext4_journal_get_write_access. Since this was also the last use of ext4_journal_get_undo_access(), I also removed the now-unneeded code in ext4_jbd2.[ch]. - Ted -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
