On Mon, May 09, 2011 at 04:05:37PM +0200, Jan Kara wrote: > Yes. ext4_append() can return ENOSPC and passed bh will get set to NULL > without being marked dirty. Ah, so the right fix then is to add to make the cleanup code like this: ext4_mark_inode_dirty(handle, dir); ext4_handle_dirty_metadata(handle, dir, frame->bh); + ext4_handle_dirty_metadata(handle, dir, bh2); + if (bh) + ext4_handle_dirty_metadata(handle, dir, bh); dx_release(frames); return retval; Agreed? - Ted -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
