On Mon, 9 May 2011, Christoph Anton Mitterer wrote: > On Mon, 2011-05-09 at 14:06 +0200, Jan Kara wrote: > > Actually, contents of the files should be generally OK > > because mkfs overwrites only inodes. So you have lost some files and > > directories but once you have a file, it should be OK. > This is really some good news!! :-) > Are you sure with that? And wouldn't mean, that inodes are always > located at the same block locations? > > > > > It's not that I wanna blame others (I mean being stupid is my fault), but > > > e2fsprogs' mkfs is really missing a check whether any known > > > filesystem/partition type/container (luks, lvm, mdadm, etc.) is already on > > > device (and a -force switch),... IIRC xfsprogs already do this more or > > > less. > > Yes, that would be reasonable although it might break some people's > > scripts. But probably worth it anyway. > IMHO the breakage is really justified then :-) > > Especially as some of those scripts might actually do their own checks > for some filesystems, but perhaps completely forget about other > containter types (partitions, LUKS, mdadm, etc. etc.) Well, it really is not justified!. We all have testing scripts where we just create filesystem over and over again because it is how it works, consider xfstests for example, there are even some tests which clears MKFS_OPTIONS completely (which should be fixet btw). However I do agree that the change should be made, but we should probably just print an warning first and then after some time, when people notice that something is going to change, make that change to refuse mkfs on existing filesystem without "-F" option. Thanks! -Lukas > > > Cheers, > Chris. > -- > To unsubscribe from this list: send the line "unsubscribe linux-ext4" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
