Pádraig Brady wrote: > On 14/04/11 16:50, Eric Sandeen wrote: >> On 4/14/11 9:59 AM, Pádraig Brady wrote: >>> On 14/04/11 15:02, Markus Trippelsdorf wrote: >>>>>> Hi Pádraig, >>>>>> >>>>>> here you go: >>>>>> + filefrag -v unwritten.withdata >>>>>> Filesystem type is: ef53 >>>>>> File size of unwritten.withdata is 5120 (2 blocks, blocksize 4096) >>>>>> ext logical physical expected length flags >>>>>> 0 0 274432 2560 unwritten,eof >>>>>> unwritten.withdata: 1 extent found >>>>>> >>>>>> Please notice that this also happens with ext4 on the same kernel. >>>>>> Btrfs is fine. >>>>> >>>> `filefrag -vs` fixes the issue on both xfs and ext4. >>> >>> So in summary, currently on (2.6.39-rc3), the following >>> will (usually?) report a single unwritten extent, >>> on both ext4 and xfs >>> >>> fallocate -l 10MiB -n k >>> dd count=10 if=/dev/urandom conv=notrunc iflag=fullblock of=k >>> filefrag -v k # grep for an extent without unwritten || fail >> >> right, that's what I see too in testing. >> >> But would the coreutils install have done a preallocation of the >> destination file? >> >> Otherwise this looks like a different bug... >> >>> This particular issue has been discussed so far at: >>> http://debbugs.gnu.org/cgi/bugreport.cgi?bug=8411 >>> Note there it was stated there that ext4 had this >>> fixed as of 2.6.39-rc1, so maybe there is something lurking? >> >> ext4 got a fix, but not xfs, I guess. My poor brain can't remember, >> I think I started looking into it, but it's clearly still broken. >> >> Still, I don't know for sure what happened to Markus - did something >> preallocate, in his case? > > Well that preallocate test is failing for him > when the source file is either on ext4 or xfs. > He noticed the issue initially on XFS when copying > none preallocated files, so XFS probably just has > the general issue of needing a sync before fiemap, > where as EXT4 just has this preallocate one > (though I've not seen it myself). FYI, I see the same failure now using ext3 (and but not w/ext4) with rawhide's 2.6.39-0.rc2.git0.0.fc16.x86_64: + df -t ext3 . + require_root_ + uid_is_privileged_ ++ id -u + my_uid=0 + case $my_uid in + NON_ROOT_USERNAME=nobody ++ id -g nobody + NON_ROOT_GROUP=99 + cwd=/t/m/ext3/tmp/coreutils-8.11.1-5995ed-dirty/tests/gt-sparse-fiemap.Qhjo + skip=0 + dd if=/dev/zero of=blob bs=32k count=1000 1000+0 records in 1000+0 records out 32768000 bytes (33 MB) copied, 1.02932 s, 31.8 MB/s + mkdir mnt + mkfs -t ext4 -F blob mke2fs 1.41.14 (22-Dec-2010) Filesystem label= OS type: Linux Block size=1024 (log=0) Fragment size=1024 (log=0) Stride=0 blocks, Stripe width=0 blocks 8000 inodes, 32000 blocks 1600 blocks (5.00%) reserved for the super user First data block=1 Maximum filesystem blocks=32768000 4 block groups 8192 blocks per group, 8192 fragments per group 2000 inodes per group Superblock backups stored on blocks: 8193, 24577 Writing inode tables: done Creating journal (1024 blocks): done Writing superblocks and filesystem accounting information: done This filesystem will be automatically checked every 21 mounts or 180 days, whichever comes first. Use tune2fs -c or -i to override. + mount -oloop blob mnt + cd mnt + echo test + test -s f + test 0 = 1 ++ seq 1 2 21 + for i in '$(seq 1 2 21)' + for j in 1 2 31 100 + perl -e 'BEGIN { $n = 1 * 1024; *F = *STDOUT }' -e 'for (1..1) { sysseek (*F, $n, 1)' -e '&& syswrite (*F, chr($_)x$n) or die "$!"}' + cp --sparse=always j1 j2 + cmp j1 j2 + filefrag -vs j1 + grep -F extent + filefrag -v j1 + filefrag -vs j2 + f ff1 + perl /t/m/ext3/tmp/coreutils-8.11.1-5995ed-dirty/tests/filefrag-extent-compare + sed 's/ [a-z,][a-z,]*$//' ff1 + awk '/^ *[0-9]/ {printf "%d %d ", $2 ,NF < 5 ? $NF : $5 } END {print ""}' + f ff2 + sed 's/ [a-z,][a-z,]*$//' ff2 + awk '/^ *[0-9]/ {printf "%d %d ", $2 ,NF < 5 ? $NF : $5 } END {print ""}' + test 0 = 1 + for j in 1 2 31 100 + perl -e 'BEGIN { $n = 1 * 1024; *F = *STDOUT }' -e 'for (1..2) { sysseek (*F, $n, 1)' -e '&& syswrite (*F, chr($_)x$n) or die "$!"}' + cp --sparse=always j1 j2 + cmp j1 j2 j1 j2 differ: char 1, line 1 <<<<================ + fail=1 -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
