https://bugzilla.kernel.org/show_bug.cgi?id=32972 --- Comment #5 from Feng Tang <feng.tang@xxxxxxxxx> 2011-04-11 02:26:43 --- > > Actually, I'm much more comfortable backing out commit 6de9843da > entirely. The above is *not* equivalent to what we had before --- > consider the case where ext4_map_blocks returns !EXT4_MAP_MAPPED && > !EXT4_MAP_UNWRITTEN. > > I don't *think* this should happen in the case where ext4_map_blocks > returns a value > 0, but the fact that it's not obvious, means I'd > much rather keep things the way that they are. It's not like dropping > the set_buffer_mapped(bh) was saving anything measurable anyway.... > > - Ted Agree for the revert and sorry for the inconvenience brought by my patch. I walked across the code when debugging a problem, and thought the patch can clean the code a little :( Thanks, Feng -- Configure bugmail: https://bugzilla.kernel.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching the assignee of the bug. -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html