From: Robin Dong <sanbai@xxxxxxxxxx> When we do performence-testing on ext4 filesystem, we observe a warning like this: "[ 1684.113205] EXT4-fs error (device sda7): ext4_mb_generate_buddy:718: group 259825901 blocks in bitmap, 26057 in gd" indeed, it should be "group 2598, 25901 blocks in bitmap, 26057 in gd" This bug is found on upstream 2.6.36 kernel. We ran a 2.6.36 kernel on the online system with 8 Ext4 file systems. 2 of them are mounted with delayed allocation feature. This warning is only observed on delayed allocation enabled Ext4 file systems. This issue is not easy to reproduce, on two servers with 2.6.36 kenrel + ext4, after running 110+ days, the error starts to appear on kernel log. When check the error log, we found the info format should be fixed, that's how this patch comes. Reviewed-by: Coly Li <bosong.ly@xxxxxxxxxx> Cc: Tao Ma <boyu.mt@xxxxxxxxxx> Signed-off-by: Robin Dong <sanbai@xxxxxxxxxx> --- fs/ext4/super.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/fs/ext4/super.c b/fs/ext4/super.c index f6a318f..bb38475 100644 --- a/fs/ext4/super.c +++ b/fs/ext4/super.c @@ -594,7 +594,7 @@ __acquires(bitlock) vaf.fmt = fmt; vaf.va = &args; - printk(KERN_CRIT "EXT4-fs error (device %s): %s:%d: group %u", + printk(KERN_CRIT "EXT4-fs error (device %s): %s:%d: group %u, ", sb->s_id, function, line, grp); if (ino) printk(KERN_CONT "inode %lu: ", ino); -- 1.7.3.5 -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
