Hi Robin, The function that has the problem isn't ;__acquire', but __ext4_grp_locked_error. the description __acquire is used for sparse check. So I guess it is a little misleading for the subject. Please change it. Thanks. btw, You can add Cc: stable@xxxxxxxxxx in your patch if you want this patch to be in stable. Regards, Tao On 03/16/2011 05:37 PM, Robin Dong wrote: > From: Robin Dong <sanbai@xxxxxxxxxx> > > When we do performence-testing on ext4 filesystem, we observe a warning > like this: > > [ 1684.113205] EXT4-fs error (device sda7): ext4_mb_generate_buddy:718: group 259825901 blocks in bitmap, 26057 in gd > > indeed, it should be > > group 2598, 25901 blocks in bitmap, 26057 in gd. > > Reviewed-by: Coly Li <bosong.ly@xxxxxxxxxx> > Signed-off-by: Robin Dong <sanbai@xxxxxxxxxx> > --- > fs/ext4/super.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/fs/ext4/super.c b/fs/ext4/super.c > index f6a318f..bb38475 100644 > --- a/fs/ext4/super.c > +++ b/fs/ext4/super.c > @@ -594,7 +594,7 @@ __acquires(bitlock) > > vaf.fmt = fmt; > vaf.va = &args; > - printk(KERN_CRIT "EXT4-fs error (device %s): %s:%d: group %u", > + printk(KERN_CRIT "EXT4-fs error (device %s): %s:%d: group %u, ", > sb->s_id, function, line, grp); > if (ino) > printk(KERN_CONT "inode %lu: ", ino); -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
