Re: [PATCH] ext3: Fix an overflow in ext3_trim_fs.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu 03-03-11 22:58:37, Tao Ma wrote:
> From: Tao Ma <boyu.mt@xxxxxxxxxx>
> 
> In a bs=4096 volume, if we call FITRIM with the following parameter as
> fstrim_range(start = 102400, len = 134144000, minlen = 10240), with the
> following code:
> if (len >= EXT3_BLOCKS_PER_GROUP(sb))
>         len -= (EXT3_BLOCKS_PER_GROUP(sb) - first_block);
> else
>         last_block = first_block + len;
> 
> So if len < EXT3_BLOCKS_PER_GROUP while first_block + len >
> EXT3_BLOCKS_PER_GROUP, last_block will be set to an overflow value
> which exceeds EXT3_BLOCKS_PER_GROUP.
> 
> This patch fixes it and adjusts len and last_block accordingly.
  Thanks. Merged.

								Honza

-- 
Jan Kara <jack@xxxxxxx>
SUSE Labs, CR
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Reiser Filesystem Development]     [Ceph FS]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux FS]     [Yosemite National Park]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Device Mapper]     [Linux Media]

  Powered by Linux