On Sat 26-02-11 22:40:19, Amir Goldstein wrote: > Orphan cleanup is currently executed even on readonly mount. > It deletes inodes and frees blocks, which could be very bad for some > RO_COMPAT features, HAS_SNAPSHOT to name one. > > Now the damage is done, because current stock kernels may > corrupt future fs with readonly compatible features, > when doing orphan cleanup. > > This patch skips the orphan cleanup if readonly compatible features > would prevent the fs from being mounted (or remounted) readwrite. Thanks Amir. I actually took the version Ted committed to ext4 and ported it for ext3. Anyway, the patch is in my tree. Honza -- Jan Kara <jack@xxxxxxx> SUSE Labs, CR -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html