On 02/23/2011 06:04 PM, Dave Chinner wrote: > This sound sort of problem indicateÑ to me that we need a generic > fiemap test in xfstests that exercises all these corner cases. > Perhaps something similar to the way I tested all the > XFS_IOC_ZERO_RANGE corner cases in test 242 by setting up all the > different hole/delalloc/unwritten/allocated combinations using > xfs_io and used the fiemap output as the golden output? > > That would catch all of these problems in the different filesystems > that implement fiemap and make sure we notice regressions pretty > quickly..... > > Cheers, > > Dave. Or, remove the "sync" calls from josef's fiemap tester: fiemap->fm_flags = FIEMAP_FLAG_SYNC; More random but would quickly blow up I bet. -Eric -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html