On 2/21/11 7:46 AM, Jan Kara wrote: > Hi Eric, > > On Fri 18-02-11 14:31:01, Eric Sandeen wrote: >> There's no good reason to require the extra step of providing >> a mount option for acl or user_xattr once the feature is configured >> on; no other filesystem that I know of requires this. >> >> Userspace patches have set these options in default mount options, >> and this patch makes them default in the kernel. At some point >> we can start to deprecate the options, perhaps. >> >> For now I've removed default mount option checks in show_options() >> to be explicit about what's set, since it's changing the default, >> but I'm open to alternatives if desired. >> >> Signed-off-by: Eric Sandeen <sandeen@xxxxxxxxxx> >> --- >> >> p.s. I've got ext2 & ext3 patches too - Jan, is this ok with >> you for ext2/3 as well? > I was thinking about this for a while. I definitely agree with the change > of default mount options in e2fsprogs (so that user_xattr and acl will be > turned on by default). But after such change is there really any bigger > point in changing the kernel defaults? Users won't have to specify options > for new filesystems because of new default mount options setting (so the > change does not bring any simplification) and for old filesystems the admin > has proper options in /etc/fstab and if not perhaps he didn't want e.g. > user_xattr to be supported so suddently turning the support on with newer > kernel will confuse them)? Well, I did this initially because Ted & Andreas seemed to want it ;) I think the idea is, we should move to deprecating and removing the options altogether. Is there any advantage to having them? And the first step to deprecating them might be to change the default. It does seem a little odd to now have the default one way in userspace, and another way in the kernel. But I'm OK either way, to be honest. Userspace alone solves my "Fedora Problem" but it leaves the kernel as kind of an oddball. -Eric > So if we wanted to do such a transition for consistency with other > filesystems, we should maybe first start warning that people should use > nouser_xattr and noacl when they really didn't want them? > Honza -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
