Re: [PATCH] ext4: reserve inodes and feature code for 'quota' feature

[Aditya Kali <adityakali@xxxxxxxxxx>]

The code 0x0080 seems to be reserved for
EXT4_FEATURE_RO_COMPAT_HAS_SNAPSHOT in e2fsprogs/lib/ext2fs/ext2_fs.h
for Next3 snapshot feature.

Thanks,
--
Aditya



On Mon, Feb 14, 2011 at 6:04 PM, Tao Ma <tm@xxxxxx> wrote:
> Hi Aditya,
> On 02/15/2011 09:06 AM, Aditya Kali wrote:
>>
>> I am working on patch to add quota as a built-in feature for ext4
>> filesystem. The implementation is based on the design given at
>> https://ext4.wiki.kernel.org/index.php/Design_For_1st_Class_Quota_in_Ext4.
>> This patch reserves the inode numbers 3 and 4 for quota purposes and
>> also reserves EXT4_FEATURE_RO_COMPAT_QUOTA feature code.
>>
>> Signed-off-by: Aditya Kali<adityakali@xxxxxxxxxx>
>> ---
>> Âfs/ext4/ext4.h | Â Â3 +++
>> Â1 files changed, 3 insertions(+), 0 deletions(-)
>>
>> diff --git a/fs/ext4/ext4.h b/fs/ext4/ext4.h
>> index 0c8d97b..127f76f 100644
>> --- a/fs/ext4/ext4.h
>> +++ b/fs/ext4/ext4.h
>> @@ -209,6 +209,8 @@ struct ext4_io_submit {
>> Â */
>> Â#define    EXT4_BAD_INO       1   Â/* Bad blocks inode */
>> Â#define EXT4_ROOT_INO Â Â Â Â Â2 Â Â Â/* Root inode */
>> +#define EXT4_USR_QUOTA_INO Â Â Â3 Â Â Â/* User quota inode */
>> +#define EXT4_GRP_QUOTA_INO Â Â Â4 Â Â Â/* Group quota inode */
>> Â#define EXT4_BOOT_LOADER_INO Â 5 Â Â Â/* Boot loader inode */
>> Â#define EXT4_UNDEL_DIR_INO Â Â 6 Â Â Â/* Undelete directory inode */
>> Â#define EXT4_RESIZE_INO Â Â Â Â Â Â Â Â7 Â Â Â/* Reserved group
>> descriptors inode */
>> @@ -1337,6 +1339,7 @@ static inline void ext4_clear_state_flags(struct
>> ext4_inode_info *ei)
>> Â#define EXT4_FEATURE_RO_COMPAT_GDT_CSUM Â Â Â Â Â Â Â 0x0010
>> Â#define EXT4_FEATURE_RO_COMPAT_DIR_NLINK Â Â Â0x0020
>> Â#define EXT4_FEATURE_RO_COMPAT_EXTRA_ISIZE Â Â0x0040
>> +#define EXT4_FEATURE_RO_COMPAT_QUOTA Â Â Â Â Â 0x0100
>>
>
> I am just wondering why 0x0080 is skipped here? It is reserved already?
>>
>> Â#define EXT4_FEATURE_INCOMPAT_COMPRESSION Â Â 0x0001
>> Â#define EXT4_FEATURE_INCOMPAT_FILETYPE Â Â Â Â Â Â Â Â0x0002
>>
>
> Regards,
> Tao
>
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html