Re: [PATCH] e2fsprogs: Fix how we treat user-spcified filesystem size

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 2011-02-01, at 12:18, Lukas Czerner wrote:
> +Optionally, the
> +.I filesystem-size
> +parameter may be suffixed by one of the following the units
> +designators: 'b', 's', 'K', 'M', or 'G',
> +for blocks count, 512 byte sectors, kilobytes, megabytes, or gigabytes,
> +respectively.

My reading of parse_num_blocks() shows that 'T' is also accepted as a suffix for terabytes, which I was otherwise going to suggest be added, since this is the normal size for filesystems today.  It might be worthwhile _briefly_ mentioning here that these are binary/power-of-two values and not decimal values, instead of the rant further below.

Minor technical nit - the proper metric value is lower-case 'k' for kilo, though the upper-case 'M', 'G', and 'T' are correct for mega-, giga-, and terabytes.

> diff --git a/resize/resize2fs.8.in b/resize/resize2fs.8.in
> --- a/resize/resize2fs.8.in
> +++ b/resize/resize2fs.8.in
> @@ -38,13 +38,13 @@ The
> +designators: 'b', 's', 'K', 'M', or 'G',
> +for blocks count, 512 byte sectors, kilobytes, megabytes, or gigabytes,
> +respectively. The

Similarly, this also supports 'T' for terabytes, since it uses the same parse_num_blocks() function.

Cheers, Andreas





--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Reiser Filesystem Development]     [Ceph FS]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux FS]     [Yosemite National Park]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Device Mapper]     [Linux Media]

  Powered by Linux