On Sun, Jan 30, 2011 at 12:07 PM, Ted Ts'o <tytso@xxxxxxx> wrote: > On Sun, Jan 30, 2011 at 11:44:25AM -0800, Manish Katiyar wrote: >> >> Do you mean separate patch for each of the changed functions ? > > Unless the cleanups for a set of functions are all the same issue, > yes. The idea is that commit description should apply to all of the > patch hunks in the commit. > > That way if there is a problem, it becomes easier to bisect and then > determine what's going on by reading the commit description. It also > becomes easier to review the changes, as well. > > Does that make sense? Hi Ted, Resending the above patch broken in following series of patch. -- Thanks - Manish -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html