On Fri, Jan 21, 2011 at 07:49:55PM -0500, Mike Snitzer wrote: > > + * If the device doesn't have writeback cache, FLUSH and FUA don't make any > > + * difference. The requests are either completed immediately if there's no > > + * data or executed as normal requests otherwise. > > For devices without a writeback cache, I'm not seeing where pure flushes > are completed immediately. But I do see where data is processed > directly in blk_insert_flush(). Yeah, it does. Pure flushes on a device w/o writeback cache, @policy is zero and blk_flush_complete_seq() will directly proceed to REQ_FSEQ_DONE. > > -struct request *blk_do_flush(struct request_queue *q, struct request *rq) > > +/** > > + * blk_abort_flush - @q is being aborted, abort flush requests > ^^^^^^^^^^^^^^^ > Small comment nit, s/blk_abort_flush/blk_abort_flushes/ Thanks. -- tejun -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
