We don't need to check whether '*options' equals to ',' twice. Signed-off-by: Simon Xu <xu.simon@xxxxxxxxxx> --- fs/ext3/super.c | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/fs/ext3/super.c b/fs/ext3/super.c index b7d0554..dbb84e6 100644 --- a/fs/ext3/super.c +++ b/fs/ext3/super.c @@ -891,13 +891,13 @@ static ext3_fsblk_t get_sb_block(void **data, struct super_block *sb) options += 3; /*todo: use simple_strtoll with >32bit ext3 */ sb_block = simple_strtoul(options, &options, 0); - if (*options && *options != ',') { + if (*options == ',') { + options++; + } else if (*options) { ext3_msg(sb, "error: invalid sb specification: %s", (char *) *data); return 1; } - if (*options == ',') - options++; *data = (void *) options; return sb_block; } -- 1.7.3.5 -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html