Re: [PATCH 03/15] mke2fs: simplify inode table block counting

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Dec 01, 2010 at 08:49:05PM +0900, Namhyung Kim wrote:
> 
> We have ext2fs_div[64]_ceil() for that. So I can use it like
> 
> ipb = fs->blocksize / EXT2_INODE_SIZE(fs->super);
> num = ext2_fs_div_ceil(fs->super->s_inodes_per_group -
> 			ext2fs_bg_itable_unused(fs, i), ipb);
> 
> or
> 
> num = ext2_fs_div_ceil((fs->super->s_inodes_per_group -
> 			ext2fs_bg_itable_unused(fs, i)) *
> 		       EXT2_INODE_SIZE(fs->super),
> 		       EXT2_BLOCK_SIZE(fs->super));
> 
> Either is fine to me. Ted, what's your preference?

I've checked in the second since it's closer to the original code.

     	     	    	   	      - Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Reiser Filesystem Development]     [Ceph FS]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux FS]     [Yosemite National Park]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Device Mapper]     [Linux Media]

  Powered by Linux