On Wed, 1 Dec 2010, Namhyung Kim wrote: > 2010-11-30 (í), 13:33 +0100, Lukas Czerner: > > On Mon, 29 Nov 2010, Namhyung Kim wrote: > > > > > In original code, 'huge' type could not be selected because it > > > always be caught for 'big' type. Change the ordering. > > > > > > Signed-off-by: Namhyung Kim <namhyung@xxxxxxxxx> > > > --- > > > misc/mke2fs.c | 4 ++-- > > > 1 files changed, 2 insertions(+), 2 deletions(-) > > > > > > diff --git a/misc/mke2fs.c b/misc/mke2fs.c > > > index 90cc206..b88decf 100644 > > > --- a/misc/mke2fs.c > > > +++ b/misc/mke2fs.c > > > @@ -947,10 +947,10 @@ static char **parse_fs_type(const char *fs_type, > > > size_type = "floppy"; > > > else if (fs_blocks_count < 512 * meg) > > > size_type = "small"; > > > - else if (fs_blocks_count >= 4 * 1024 * 1024 * meg) > > > - size_type = "big"; > > > else if (fs_blocks_count >= 16 * 1024 * 1024 * meg) > > > size_type = "huge"; > > > + else if (fs_blocks_count >= 4 * 1024 * 1024 * meg) > > > + size_type = "big"; > > > else > > > size_type = "default"; > > > > > > > > > > Personally, I do not like it very much. Either sort this in ascending order > > and use "<" or sort it in descending order and use ">=". But since it > > was originally sorted in ascending order I would do that this way. > > > > -Lukas > > No problem. You mean "floppy, small, default, big and huge", right? I'll > resend v2 if you prefer that, Ted. > > Thanks. > Right. Thanks! -Lukas
