On Tue, 16 Nov 2010, yangsheng wrote:
> The jbd2_stats_proc_init() was placed on wrong location in
> jbd2_journal_init_dev(). This may cause /proc/fs/jdb2/<dev>/*
> cannot be created when using external journal device.
>
> Reviewed-by: Andreas Dilger <andreas.dilger@xxxxxxxxxx>
Code looks good to me and after a quick testing it seems to be working
properly.
-Lukas
>
> ---
> ---
> fs/jbd2/journal.c | 16 ++++++++--------
> 1 files changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/fs/jbd2/journal.c b/fs/jbd2/journal.c
> index c590d15..f837ba9 100644
> --- a/fs/jbd2/journal.c
> +++ b/fs/jbd2/journal.c
> @@ -899,6 +899,14 @@ journal_t * jbd2_journal_init_dev(struct block_device *bdev,
>
> /* journal descriptor can store up to n blocks -bzzz */
> journal->j_blocksize = blocksize;
> + journal->j_dev = bdev;
> + journal->j_fs_dev = fs_dev;
> + journal->j_blk_offset = start;
> + journal->j_maxlen = len;
> + bdevname(journal->j_dev, journal->j_devname);
> + p = journal->j_devname;
> + while ((p = strchr(p, '/')))
> + *p = '!';
> jbd2_stats_proc_init(journal);
> n = journal->j_blocksize / sizeof(journal_block_tag_t);
> journal->j_wbufsize = n;
> @@ -908,14 +916,6 @@ journal_t * jbd2_journal_init_dev(struct block_device *bdev,
> __func__);
> goto out_err;
> }
> - journal->j_dev = bdev;
> - journal->j_fs_dev = fs_dev;
> - journal->j_blk_offset = start;
> - journal->j_maxlen = len;
> - bdevname(journal->j_dev, journal->j_devname);
> - p = journal->j_devname;
> - while ((p = strchr(p, '/')))
> - *p = '!';
>
> bh = __getblk(journal->j_dev, start, journal->j_blocksize);
> if (!bh) {
>
--
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
