Since the discard may take quite long time, especially with really big extents (like the whole device for example), it would be nice to give to users the opportunity to abort it. This is especially useful for mkfs, when user can not know in advance how long it will take. In conjunction with mke2fs patch "Inform user about ongoing discard" it gives the user all the comfort of being informed about discard and being able to abort the operation. It has been tested on SSD device where mkfs.ext4 without -K takes rally long due to discarding whole device. With this patch I am able to successfully terminate that with ctrl+c. Aside that discard functionality remains unchanged. Signed-off-by: Lukas Czerner <lczerner@xxxxxxxxxx> --- block/blk-lib.c | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/block/blk-lib.c b/block/blk-lib.c index c392029..54994e7 100644 --- a/block/blk-lib.c +++ b/block/blk-lib.c @@ -101,6 +101,9 @@ int blkdev_issue_discard(struct block_device *bdev, sector_t sector, else if (!bio_flagged(bio, BIO_UPTODATE)) ret = -EIO; bio_put(bio); + + if (unlikely(fatal_signal_pending(current))) + ret = -ERESTARTSYS; } return ret; -- 1.7.2.3 -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
