On Sat 09-10-10 19:28:39, Dmitry Monakhov wrote:
> It must be already acquired by caller. Fix lock_dep complain.
The patch is OK, but Ted usually merges ext4 patches (even quota related,
unless they are dependent on other generic quota stuff).
Honza
>
> Signed-off-by: Dmitry Monakhov <dmonakhov@xxxxxxxxx>
>
> diff --git a/fs/ext4/super.c b/fs/ext4/super.c
> index e59eb37..062d1bc 100644
> --- a/fs/ext4/super.c
> +++ b/fs/ext4/super.c
> @@ -4107,12 +4107,10 @@ static int ext4_quota_on(struct super_block *sb, int type, int format_id,
>
> static int ext4_quota_off(struct super_block *sb, int type)
> {
> - /* Force all delayed allocation blocks to be allocated */
> - if (test_opt(sb, DELALLOC)) {
> - down_read(&sb->s_umount);
> + /* Force all delayed allocation blocks to be allocated.
> + * Caller already holds s_umount sem */
> + if (test_opt(sb, DELALLOC))
> sync_filesystem(sb);
> - up_read(&sb->s_umount);
> - }
>
> return dquot_quota_off(sb, type);
> }
--
Jan Kara <jack@xxxxxxx>
SUSE Labs, CR
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
