Re: [PATCH] don't use ext4_allocation_contexts for tracing

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Aug 20, 2010 at 02:51:43PM -0500, Eric Sandeen wrote:
> Many tracepoints were populating an ext4_allocation_context
> to pass in, but this requires a slab allocation even when
> tracepoints are off.  In fact, 4 of 5 of these allocations
> were only for tracing.  In addition, we were only using a
> small fraction of the 144 bytes of this structure for this
> purpose.
> 
> We can do away with all these alloc/frees of the ac and
> simply pass in the bits we care about, instead.
> 
> I tested this by turning on tracing and running through
> xfstests on x86_64.  I did not actually do anything with
> the trace output, however.
> 
> Signed-off-by: Eric Sandeen <sandeen@xxxxxxxxxx>

Added to the patch tree, thanks!

I made a slight change to drop passing in the logical parameter to
trace_ext4_mballoc_discard() and trace_ext4_mballoc_free(), since
passing in 0 all the time doesn't really buy us much.  :-)

	     	     	  	  	 - Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Reiser Filesystem Development]     [Ceph FS]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux FS]     [Yosemite National Park]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Device Mapper]     [Linux Media]

  Powered by Linux