On Mon 04-10-10 17:26:53, Namhyung Kim wrote: > Move call to jbd_debug() into #ifdef CONFIG_JBD_DEBUG block because > 'dropped' is declared there. The code could be compiled without this > change anyway, simply because jbd_debug() expands to nothing if > !CONFIG_JBD_DEBUG but IMHO it doesn't look good in general. > > Signed-off-by: Namhyung Kim <namhyung@xxxxxxxxx> Thanks. Merged into my tree. Honza > --- > fs/jbd/recovery.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/fs/jbd/recovery.c b/fs/jbd/recovery.c > index 81051da..5b43e96 100644 > --- a/fs/jbd/recovery.c > +++ b/fs/jbd/recovery.c > @@ -296,10 +296,10 @@ int journal_skip_recovery(journal_t *journal) > #ifdef CONFIG_JBD_DEBUG > int dropped = info.end_transaction - > be32_to_cpu(journal->j_superblock->s_sequence); > -#endif > jbd_debug(1, > "JBD: ignoring %d transaction%s from the journal.\n", > dropped, (dropped == 1) ? "" : "s"); > +#endif > journal->j_transaction_sequence = ++info.end_transaction; > } > > -- > 1.7.0.4 > -- Jan Kara <jack@xxxxxxx> SUSE Labs, CR -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
