On 2010-09-08, at 10:59, Lukas Czerner wrote: > +static inline int sb_issue_zeroout(struct super_block *sb, > + sector_t block, sector_t nr_blocks) > +{ > + block <<= (sb->s_blocksize_bits - 9); > + nr_blocks <<= (sb->s_blocksize_bits - 9); > + return blkdev_issue_zeroout(sb->s_bdev, block, nr_blocks, GFP_KERNEL, > + BLKDEV_IFL_WAIT | BLKDEV_IFL_BARRIER); > +} While I can understand that we might need a barrier for this (to avoid it being reordered with later writes that are using these blocks), I'm not sure it needs to wait for previous IO to complete. Cheers, Andreas -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html