Bill Fink wrote: > On Mon, 30 Aug 2010, Eric Sandeen wrote: ... >> When I get some time (soon I hope) I'll look into the ramifications >> of this change (i.e. what if wbc->nr_to_write * 8 is more than the dirty >> pages, do things work out ok?) but it seems pretty reasonable. > > In thinking about that issue, my non-expert thought was that > if desired_nr_to_write was larger, it hopefully wouldn't be an > issue since presumably it's only going to actually write at most > the number of dirty pages anyway. And on the flip side, there > doesn't seem to be an issue with desired_nr_to_write possibly > being smaller that it was without the patch, since the empirical > evidence is that the performance significantly improved with the > patch, and the effect of a lower value would presumably be > reduced performance. > > -Bill Ted's suggestion of capturing blktrace data would be a really great step towards understanding what changed, too. Thanks! -Eric -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
