On Tue, Aug 24, 2010 at 9:41 AM, Eric Sandeen <sandeen@xxxxxxxxxx> wrote: > Andreas Dilger wrote: > >> This isn't the first time that we've had problems like this, and it >> won't be the last time unless there is a better API for checking >> these flags. > > *nod* > On a related note (to my original problem)... is the bad i_blocks count fixup code in the check_blocks() function of pass1.c broken for large files, or am I misunderstanding the code? pb.num_blocks and ext2fs_inode_i_blocks() are both >32 bits, but the fixup code appears to always try to shove pb.num_blocks into the 32-bit inode->i_blocks and set inode->osd2.linux2.l_i_blocks_hi = 0. -Justin -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
