Hi, The patch looks good. Just one small thing: On Wed 04-08-10 15:44:34, Lukas Czerner wrote: > + gdp = ext3_get_group_desc(sb, group, &gdp_bh); > + if (!gdp) > + goto err_out; > + > + BUFFER_TRACE(gd_bh, "get_write_access"); ^^^^^ gdp_bh So you can add: Reviewed-by: Jan Kara <jack@xxxxxxx> Honza -- Jan Kara <jack@xxxxxxx> SUSE Labs, CR -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html