On Tue, Aug 03, 2010 at 11:55:39AM -0600, Andreas Dilger wrote:
> On 2010-08-01, at 21:15, Theodore Ts'o wrote:
> > Allow mount options to be stored in the superblock. Also add default
> > mount option bits for nobarrier, block_validity, discard, and nodelalloc.
>
> Don't we already store mount options in s_default_mount_opts? It
> seems more efficient to store them as binary flags instead of as a
> string.
For mount options that are going to be around for a long time, this
makes sense and it is indeed the preferred mechanism. The problem is
that if we are adding and removing mount options, perhaps for internal
testing purposes using binary bitfields don't work as well, because
(a) it means we have to synchronize e2fsprogs with the kernel updates,
and (b) once used, it's hard to recycle a binary bit position since
there might be old file systems around. So the 64 byte character
array is intended to be used as an adjunct for the binary bitfield.
- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
