On Mon, Jun 28, 2010 at 09:58:53AM -0500, Eric Sandeen wrote: > Toshiyuki Okajima wrote: > > From: Toshiyuki Okajima <toshi.okajima@xxxxxxxxxxxxxx> > > > > You know, do_truncate() can call ext4_setattr() (via notify_change()). > > And, ext4_setattr() can return with -EFBIG if the argument(length) of > > do_truncate() is more than sbi->s_bitmap_maxbytes. At that time, > > it also calls ext4_std_error() with -EFBIG. > > > > Besides, a panic happens when ext4_setattr() returns with -EFBIG > > after we mount an ext4 filesystem with errors=panic. > > ... > > > This changes prevent this problem from happening. > > Whoops, that one was my fault; thanks for catching it. > > I might just "return error" at that spot, but this works fine too. I've fixed this by simply returning EFBIG at that spot, since that's a bit simpler and it reduces the line count to boot. Toshiyuki-san, thanks for pointing this out! - Ted -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
