On Wed, Jul 21, 2010 at 12:11 AM, Greg Freemyer <greg.freemyer@xxxxxxxxx> wrote: > > So are you just asking for comments right now, or are you asking that > the e2fsprogs patches get applied? > I am asking that the patches will get applied. comments are always welcome. I am looking for 2 types of code review: 1. check that the patch looks good in general and doesn't change behavior when the snapshot feature is disabled. that kind of review would approve that the patch may be applied to the master branch. 2. check the behavior of the code when snapshot feature is enabled. this requires the reviewer to acquire some knowledge about the design of the snapshot feature. > Maybe a separate e2fsprogs branch for next3 should be created like > there was for the 64-bit patches? (That would be Ted/Jan's call, not > mine.) > That's not my call, but I do not think that would be necessary. the next3 e2fsprogs patches are really small and are restricted to a small number of files. for that reason, it wasn't so hard for me to rebase them from the maint branch to the master branch (64bit code). there is some dependency among the patches, but most of them are small and independent, so they don't have to be applied all at once. I also verified that every sub-series of the patches builds with no errors. To put it in other words, any review, of any type, of any patch, would be helpful. Thanks, Amir. -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
