On Tue 22-06-10 17:52:00, tytso@xxxxxxx wrote: > On Tue, Jun 22, 2010 at 10:29:27PM +0200, Jan Kara wrote: > > With metadata which get journaled it should be quite easy. JBD already > > must know before you go and modify buffer contents - that's why > > journal_get_write_access and friends exist. It also makes sure that your > > data cannot be modified from the moment the buffer enters commit upto the > > moment the commit is finished. So you can use buffer commit hook to compute > > and store block checksum safely. > > True, but we're also interested in making sure this feature can be > used in the non-journal case as well.... Ah, I forgot about that... Doing per-block checksums in that case would be indeed more complicated. So computing checksum for each dquot is probably simpler. Honza -- Jan Kara <jack@xxxxxxx> SUSE Labs, CR -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html