Re: [PATCH 4/8] e2fsprogs: Next3 snapshot control with chattr/lsattr -X

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> +static struct flags_name snapshot_flags_array[] = {
> +	{ NEXT3_SNAPFILE_LIST_FL, "S", "on_liSt" },
> +	{ NEXT3_SNAPFILE_ENABLED_FL, "n", "eNabled" },
> +	{ NEXT3_SNAPFILE_ACTIVE_FL, "a", "Active" },
> +	{ NEXT3_SNAPFILE_INUSE_FL, "p", "inuse_by_Previous" },
> +	{ NEXT3_SNAPFILE_DELETED_FL, "s", "Deleted" },
> +	{ NEXT3_SNAPFILE_SHRUNK_FL, "h", "sHrunk" },
> +	{ NEXT3_SNAPFILE_OPEN_FL, "o", "mOunted" },
> +	{ NEXT3_SNAPFILE_TAGGED_FL, "t", "Tagged" },
>  	{ 0, NULL, NULL }
>  };

While clever, I don't think this necessarily makes for a good user interface.
In comparison, flags "l, e, a, i, d, s, m ,t" respectively make much easier to understand/remember name abbreviations.

Cheers, Andreas
--
Andreas Dilger
Lustre Technical Lead
Oracle Corporation Canada Inc.

--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Reiser Filesystem Development]     [Ceph FS]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux FS]     [Yosemite National Park]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Device Mapper]     [Linux Media]

  Powered by Linux