On Tue, May 25, 2010 at 06:28:29PM +0400, Dmitry Monakhov wrote: > tytso@xxxxxxx writes: > > > On Thu, Apr 22, 2010 at 08:31:11AM +0400, Dmitry Monakhov wrote: > >> @@ -2480,6 +2480,11 @@ static int ext4_ext_remove_space(struct inode *inode, ext4_lblk_t start) > >> out: > >> ext4_ext_drop_refs(path); > >> kfree(path); > >> + if (err == EAGAIN) { > > > > Surely this should be "err == -EAGAIN", no? I'm curious how this > > patch worked for with this typo.... > As usually it fix one thing, and broke another :(. > So in case of alloc/truncate restart truncate will be aborted, > so i_size != i_disk_size which must be caught by fsck (my test run > it every time) but this never happens which is very strange. What test case are you using? And does it require a system crash to show up, or are you seeing an fsck problem after the test completes and you unmount the file system? - Ted -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html