On Wed, Apr 28, 2010 at 08:53:01PM +0400, Dmitry Monakhov wrote: > If we have failed some where inside ext4_get_blocks() internals we may > have allocated some new blocks, which was not yet claimed to quota. > We have to free such blocks, but without touching quota. Quota will > be updated later on exit from ext4_get_blocks(). > There are two possible ways to understand what we have to skip quota update: > 1) Caller pass corresponding flag to ext4_free_blocks() > 2) check that free_blocks() was indirectly called by get_blocks() > (i.e EXT4_I(inode)->i_delalloc_reserved_flag is set) > Second is simpler, but may result in unpredictable consequences later. > So i've chosen the first one, because caller must know which blocks it > is freeing. > > Eric, please take your attention to metadata blocks handling when > you will work on new versing of "ext4: don't use quota reservation for > speculative metadata blocks" patch. This patch needs to be carefully changed after Eric's patch has gone in (which I've already applied into the patch queue). As a result I'm going to hold off applying your patch until either (a) someone (probably you or I) has a chance to fix it up in light of Eric's changes. I'm not sure I'll get to it before I need to push patches to Linus, though, so it might miss the merge window. If we can make this a simple and easy to vet bugfix, I might be able to push it through as a supplementary bug fix push. - Ted -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
