On 05/14/2010 08:29 AM, Jiaying Zhang Wrote: > On Thu, May 13, 2010 at 2:08 AM, Coly Li <coly.li@xxxxxxx> wrote: >> >> >> On 05/13/2010 01:00 PM, Jiaying Zhang Wrote: >>> This patch issues discard request for freed blocks in ext4_free_blocks() >>> if ext4 is mounted with discard option and without journal. >>> >>> Author: Jiaying Zhang <jiayingz@xxxxxxxxxx> >>> Date: � Wed May 12 21:11:46 2010 -0700 >>> >>> � � Issue discard request in ext4_free_blocks() when ext4 has no journal and >>> � � is mounted with discard option. >>> >>> � � Signed-off-by: Jiaying Zhang <jiayingz@xxxxxxxxxx> >>> >>> diff --git a/fs/ext4/mballoc.c b/fs/ext4/mballoc.c >>> index a291cc3..d51b79a 100644 >>> --- a/fs/ext4/mballoc.c >>> +++ b/fs/ext4/mballoc.c >>> @@ -2513,6 +2513,22 @@ int ext4_mb_release(struct super_block *sb) >>> � � � return 0; >>> �} >>> >>> +static void ext4_issue_discard(struct super_block *sb, ext4_group_t block_group, [snip] >> >> How about make it as an inline routine? Thanks. > > Ok. I changed it to inline. The modified patch is attached. > - Acked-by: Coly Li <coly.li@xxxxxxx> + Reviewed-by: Coly Li <coly.li@xxxxxxx> Thanks. -- Coly Li SuSE Labs -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html