On 2010-05-13, at 09:04, James Bottomley wrote: > This isn't necessarily true ... most drivers and filesystems have to > know what type they're getting. Often they have to do extra tricks to > process vmalloc areas. Conversely, large kmalloc areas are a very > precious commodity: if a driver or filesystem can handle vmalloc for > large allocations, it should: it's easier for us to expand the vmalloc > area than to try to make page reclaim keep large contiguous areas ... I > notice your proposed API does the exact opposite of this ... tries > kmalloc first and then does vmalloc. > > Given this policy problem, isn't it easier simply to hand craft the > vmalloc fall back to kmalloc (or vice versa) in the driver than add this > whole massive raft of APIs for it? I know we wouldn't mind using large vmalloc allocations for e.g. per-group arrays in ext4 (allocated once per mount), but I'd always understood that using vmalloc for general purpose uses can have a significant impact because the vmalloc() engine has (had?) serious performance problems. That means it is better performance-wise to have a wrapper function like this to switch between kmalloc() and vmalloc() based on the allocation size, but it makes the code ugly. Having the wrapper in the kernel would at least identify the different places that are using this kind of workaround. If the performance of vmalloc() has been improved in the last few years, then I'd be happy to just use vmalloc() all the time. That said, vmalloc still isn't suitable for sub-page allocations, so if you have a variable-sized allocation that may be very small or very large the small allocations will waste a whole page and a wrapper is still needed, or vmalloc should be changed to call kmalloc/kfree for the sub-page allocations. Cheers, Andreas -- Andreas Dilger Lustre Technical Lead Oracle Corporation Canada Inc. -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
