On 2010-04-29, at 00:13, Coly Li wrote: >> + /* >> + * Let individual file system decide if it supports >> + * preallocation for directories or not. >> + */ >> + if (offset > inode->i_sb->s_maxbytes) >> + return -EFBIG; > > For file systems support online-resize, like ext4 and ocfs2, should we also need a locking to protect inode->i_sb->s_mabytes ? s_maxbytes is the maximum theoretical single file size, and has nothing to do with the size of the filesystem. Cheers, Andreas -- Andreas Dilger Sr. Staff Engineer, Lustre Group Sun Microsystems of Canada, Inc. -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
