Vivek Goyal <vgoyal@xxxxxxxxxx> writes: > On Wed, Apr 14, 2010 at 05:17:03PM -0400, Jeff Moyer wrote: >> @@ -3678,11 +3710,14 @@ static void *cfq_init_queue(struct request_queue *q) >> >> /* Init root service tree */ >> cfqd->grp_service_tree = CFQ_RB_ROOT; >> + cfqd->grp_service_tree.last_end_request = jiffies; >> > > This assignment is not required as we never update think time analsys of > service tree where all the groups are hanging. So for grp_service_tree, > last_end_request can be zero and there will be no harm. OK, thanks. > Otherwise patch looks good to me. Can you please run some simple blkio > cgroup tests to make sure that functionality is not broken. Yes, I'll add that to my list and get back to you. Thanks for the review, Vivek. Cheers, Jeff -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
