2010/3/31, Andreas Dilger <adilger@xxxxxxx>:
> On 2010-03-30, at 06:36, jing zhang wrote:
>> --- linux-2.6.32/fs/ext4/mballoc.c 2009-12-03 11:51:22.000000000 +0800
>> +++ ext4_mm_leak/mballoc-13.c 2010-03-30 20:28:08.000000000 +0800
>> @@ -4183,12 +4183,20 @@ static int ext4_mb_discard_preallocation
>> trace_ext4_mb_discard_preallocations(sb, needed);
>> - for (i = 0; i < ngroups && needed > 0; i++) {
>> - ret = ext4_mb_discard_group_preallocations(sb, i, needed);
>> + if (needed <= 0)
>> + return freed;
>> + for (i = 0; i < ngroups; i++) {
>> + if (grp_cache >= ngroups)
>> + grp_cache -= ngroups;
>> + ret = ext4_mb_discard_group_preallocations(sb, grp_cache, needed);
>
>
> Anything that is walking every group in the filesystem is going to hit
> problems on large filesystems. This seems like something that needs
> to be fixed in a different way (e.g. keeping a list of preallocations).
>
> Cheers, Andreas
> --
> Andreas Dilger
> Sr. Staff Engineer, Lustre Group
> Sun Microsystems of Canada, Inc.
>
>
Then please take the following also into consideration.
Thanks
- zj
---
--- linux-2.6.32/fs/ext4/mballoc.c 2009-12-03 11:51:22.000000000 +0800
+++ ext4_mm_leak/mballoc-14.c 2010-04-01 20:35:58.000000000 +0800
@@ -4299,7 +4299,7 @@ repeat:
}
} else {
freed = ext4_mb_discard_preallocations(sb, ac->ac_o_ex.fe_len);
- if (freed)
+ if (freed && freed >= ac->ac_o_ex.fe_len)
goto repeat;
*errp = -ENOSPC;
ac->ac_b_ex.fe_len = 0;
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
