jing zhang wrote:
> From: Jing Zhang <zj.barak@xxxxxxxxx>
>
> Date: Sun Mar 28 17:09:33 2010
>
> rb_tree cache is added to struct ext4_group_info at minor cost.
Please include a reason for the change in the commit message,
so that in the future people don't have to figure out for
themselves why a change was made. It also helps reviewers. :)
...
> @@ -4376,7 +4384,7 @@ ext4_mb_free_metadata(handle_t *handle,
> if (block < entry->start_blk)
> n = &(*n)->rb_left;
> else if (block >= (entry->start_blk + entry->count))
> - n = &(*n)->rb_right;
> + n = &(*n)->rb_right, left = 0;
> else {
> ext4_grp_locked_error(sb, e4b->bd_group, __func__,
> "Double free of blocks %d (%d %d)",
I think it's better if you don't use that style, but instead:
else if (block >= (entry->start_blk + entry->count)) {
n = &(*n)->rb_right;
left = 0;
} else {
...
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
