(2010/03/16 0:41), tytso@xxxxxxx wrote:
On Mon, Mar 15, 2010 at 03:42:39PM +0100, Stefan Richter wrote:
Hi,
I saw the following scroll by during kernel compilation:
fs/ext4/move_extent.c: In function 'mext_leaf_block':
fs/ext4/move_extent.c:478: warning: 'start_ext.ee_block' may be used
uninitialized in this function
Is it real? It seems that the initial start_ext.ee_len = 0 guards
against accidental use of an uninitialized start_ext.ee_block, but maybe
I missed something.
From my review of the code the fact that ee_len is set to zero should
make this be safe, but my preference would be to clear
start_ext.ee_block as well to prevent the warning from coming up
(since false positives clutter up warnings and might cause us to miss
a warning which isn't so benign).
Akira-san, do you agree that it is currently is safe?
Sorry for the late reply.
The patch (gcc-wall-cleanup-in-move_extent.c) in ext4 patch queue
looks good to me.
Thanks,
Akira Fujita
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
