On 03/24/2010 11:12 AM, tytso@xxxxxxx wrote:
> Thanks for catching this! This should fix it up...
>
> - Ted
>
> ext4: Fix build error when EXT4_USE_FOR_EXT23 disabled
>
> Fix a stupid type (CONTIG != CONFIG) and a stupid assumption that
> ext3_fs_type would always be defined.
>
> (The build failure could also happen when EXT4_USE_FOR_EXT23 is
> enabled and ext3 is built as a module.)
A little late, but right now we have this in Kconfig:
config EXT4_USE_FOR_EXT23
bool "Use ext4 for ext2/ext3 file systems"
depends on EXT4_FS
depends on EXT3_FS=n || EXT2_FS=n
do we really want "||" ?
so, if you turn off ext2, but leave ext3 on, it will ask you if you want
to use ext4 for ext3? That doesn't make sense to me.
Shouldn't it be:
- depends on EXT3_FS=n || EXT2_FS=n
+ depends on EXT3_FS=n && EXT2_FS=n
?
-Eric
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
