Re: [PATCH] ext4: remove unnecessary operation in ext4_mb_regular_allocator()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 2010-03-22, at 08:35, jing zhang wrote:
@@ -2027,7 +2027,7 @@ repeat:

		for (i = 0; i < ngroups; group++, i++) {
			struct ext4_group_info *grp;
-			struct ext4_group_desc *desc;
+			/* struct ext4_group_desc *desc; */

			if (group == ngroups)
				group = 0;
@@ -2045,12 +2045,12 @@ repeat:

			ac->ac_groups_scanned++;
-			desc = ext4_get_group_desc(sb, group, NULL);
+			/* desc = ext4_get_group_desc(sb, group, NULL); */
			if (cr == 0)
				ext4_mb_simple_scan_group(ac, &e4b);
			else if (cr == 1 &&


Rather than commenting these lines out, please just delete them. They serve no purpose, and leaving them in the code will just add confusion in the future.

Cheers, Andreas
--
Andreas Dilger
Sr. Staff Engineer, Lustre Group
Sun Microsystems of Canada, Inc.

--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Reiser Filesystem Development]     [Ceph FS]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux FS]     [Yosemite National Park]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Device Mapper]     [Linux Media]

  Powered by Linux