On Fri, Mar 12, 2010 at 08:26:49PM +0300, Dmitry Monakhov wrote: > start_journal_io: > + if (bufs) > + commit_transaction->t_flushed_data_blocks = 1; > + I'm not convinced this is right. >From your test case, the problem isn't because we have journaled metadata blocks (which is what bufs) counts, but because fsync() depends on data blocks also getting flushed out to disks. However, if we aren't closing the transaction because of fsync(), I don't think we need to do a barrier in the case of an external journal. So instead of effectively unconditionally setting t_flushed_data_blocks (since bufs is nearly always going to be non-zero), I think the better fix is to test to see if the journal device != to the fs data device in fsync(), and if so, start the barrier operation there. Do you agree? Best regards, - Ted -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
