On Tue, Mar 02, 2010 at 12:37:43PM +0300, Dmitry Monakhov wrote:
> Jan Kara <jack@xxxxxxx> writes:
>
> > On Tue 16-02-10 19:33:41, Dmitry Monakhov wrote:
> >> We always assume what dquot update result in changes in one data block
> >> But ext4_quota_write() function may handle cross block boundary writes
> >> In fact if this ever happen it will result in incorrect journal credits
> >> reservation. And later bug_on triggering. As soon this never happen the
> >> boundary cross loop is NOOP. In order to make things straight
> >> let's remove this loop and assert cross boundary condition.
> >>
> >> Signed-off-by: Dmitry Monakhov <dmonakhov@xxxxxxxxxx>
> > Yeah, originally I thought it might be useful to support a possibility of
> > multiblock writes but in the end we never needed it and currently e.g. OCFS2
> > would already BUG on that so yes, this is a good simplification.
> > Acked-by: Jan Kara <jack@xxxxxxx>
> >
> > I've merged the ext3 version of the patch into my tree. Ted, will you
> > merge this ext4 cleanup please?
> Ted please take a look at the patch.
Sorry, I had lost track of this patch. I've added it to the ext4 patch queue.
- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
