On Fri, Jan 29, 2010 at 02:28:23PM -0600, Eric Sandeen wrote: > The "offset" member in ext4_io_end holds bytes, not > blocks, so ext4_lblk_t is wrong - and too small (u32) > > This caused the testcase "Possible ext4 data corruption > with large files and async I/O" sent by Giel to fail when it > wrapped around to 0. > > Also fix up the type of arguments to > ext4_convert_unwritten_extents(), it gets ssize_t from > ext4_end_aio_dio_nolock() and ext4_ext_direct_IO() > > Reported-by: Giel de Nijs <giel@xxxxxxxxxxxxxx> > Signed-off-by: Eric Sandeen <sandeen@xxxxxxxxxx> > --- > > V2: Post-review Josef spotted another size_t in ext4_end_aio_dio_nolock() > Reviewed-by: Josef Back <josef@xxxxxxxxxx> probably should have said something before replying to the last email :). Thanks, Josef -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
