On Tue, Jan 26, 2010 at 08:32:22AM -0700, Jan Kara wrote:
> @@ -2127,17 +2127,16 @@ static void ext4_da_block_invalidatepages(struct mpage_da_data *mpd,
> break;
> for (i = 0; i < nr_pages; i++) {
> struct page *page = pvec.pages[i];
> - index = page->index;
> - if (index > end)
> + if (page->index > end)
> break;
> - index++;
> -
> BUG_ON(!PageLocked(page));
> BUG_ON(PageWriteback(page));
> block_invalidatepage(page, 0);
> ClearPageUptodate(page);
> unlock_page(page);
> }
> + index = pvec.pages[nr_pages - 1]->index + 1;
> + pagevec_release(&pvec);
> }
> return;
> }
The patch includes a cleanup and a bug fix, both looks OK to me.
But if we can split it, the bug fix would be good candidate for
the stable kernel?
Thanks,
Fengguang
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
