On 2010-01-22, at 10:42, Eric Sandeen wrote:
tytso@xxxxxxx wrote:
On Thu, Jan 21, 2010 at 05:22:55PM -0700, Andreas Dilger wrote:
Alasdair, any chance you can include this script into the LVM
package?
Ted, this should really be added to e2fsprogs, and the e2croncheck
script removed. The existing e2croncheck script is broken in a
number of ways (e.g. the force check timestamp 19000101 is invalid,
the email reporting doesn't work because "$RPT-EMAIL" is never set)
and is less functional in other ways (it doesn't remove stale
snapshots in case of an interrupted script, it doesn't check
multiple LVs, etc).
Sure, I'd be happy to include this to e2fsprogs. I'm not sure which
distro package should be installing it, but we can leave that up to
the distro maintainers.
Last time around, we all seemed to think it should be in the lvm
tools (though I don't remember exactly why - probably because it's
really not ext*-specific at all)
Sure, but since there is only a semi-functional version in e2fsprogs
we may as well replace it with a working one.
It got forwarded to the LVM list, agk asked if anyone wanted to
clean it up & take ownership of it, and that was the end. :(
I guess I wasn't on that email. I've gone ahead and fixed up the
current script to be functional (including testing of failed-fsck
email, force-fsck on next boot, stale snapshot cleanup, etc) so you
may as well chalk me up as the maintainer for now.
Cheers, Andreas
--
Andreas Dilger
Sr. Staff Engineer, Lustre Group
Sun Microsystems of Canada, Inc.
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
