On 2010-01-20, at 11:58, Eric Sandeen wrote:
Mingming wrote:
I am a little lost why doing vmtruncate here...
Hm first off I assume vmtruncate will clear blocks past that size,
but tonight I'm not seeing how it gets there.
Anyway, it looks like any setting of the size, truncate up or down
(or to current size) will clear any blocks past EOF.
Why not just call ext4_truncate(inode)? Since these blocks are only
fallocated, and pages couldn't (shouldn't?) be instantiated beyond
i_size, we don't need to do anything at the mapping level, only at the
inode level.
Well here we are clearing the EOFBLOCKS flag so we'd want to clear any
blocks past EOF.... but now, does vmtruncate do that?
Ok, count me as confused too, but mostly jsut so far as how does
vmtruncate clear the blocks beyond eof. I guess I glossed over this
when reading it.
Has the new truncate API patchset gone into the kernel? I recall
there was some work to restructure the API and maybe you are a victim
of understanding the old API?
Cheers, Andreas
--
Andreas Dilger
Sr. Staff Engineer, Lustre Group
Sun Microsystems of Canada, Inc.
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
