On Sun, Jan 17, 2010 at 10:19:30AM -0600, Eric Sandeen wrote:
> In addition to Aneesh's suggestions, I'm not sure of the value of
> creating more
>
> #define FLAG_A = FLAG_B|FLAG_C
>
> flag macros; unless you have this all in your head you just have to
> go look up the flag definition anyway, since we usually test individual
> flags not the aggregates. I'm wondering if it might be better to just
> explicitly send in the OR'd flags rather than creating a new one, to
> see the code flow better.
I'd agree with that. The other reason why it's good to avoid
aggregates is that if you don't realize that that FLAG_A is an
aggregate, you can end up doing this:
if (flag & FLAG_A) {
...
}
and then be surprise when this tests true not just when someone passed
in FLAG_A, but also if someone passes in FLAG_B or FLAG_C...
- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
